Issue / 9181 Implement Conversion Reporting Specific Internal Tracking #9867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lProductsSubtleNotification.
…ellProductsSubtleNotification.
…label if user saves KMW selection with ACR metrics.
10upsimon
changed the title
|
Build files for 54bc7a6 have been deleted. |
|
Size Change: +899 B (+0.05%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
10upsimon
changed the title
zutigrm
previously requested changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks @10upsimon Nice work, it is pretty big PR. I left you few comments
assets/js/components/KeyMetrics/MetricsSelectionPanel/Footer.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/Footer.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/Footer.js
Outdated
Show resolved
Hide resolved
…rnal-tracking' of github.com:google/site-kit-wp into issue/9181-implement-conversion-reporting-specific-internal-tracking.
|
Thanks @10upsimon LGTM |
tofumatt
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Looks good to me, just waiting on @10upsimon to confirm it looks right 🙂
assets/js/components/KeyMetrics/MetricsSelectionPanel/Footer.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Riley MacPherson <[email protected]>
…rnal-tracking' of github.com:google/site-kit-wp into issue/9181-implement-conversion-reporting-specific-internal-tracking.
…rnal-tracking' of github.com:google/site-kit-wp into issue/9181-implement-conversion-reporting-specific-internal-tracking.
…rnal-tracking' of github.com:google/site-kit-wp into issue/9181-implement-conversion-reporting-specific-internal-tracking.
…rnal-tracking' of github.com:google/site-kit-wp into issue/9181-implement-conversion-reporting-specific-internal-tracking.
…her combined tracking logic in utils.js.
tofumatt
approved these changes
Dec 23, 2024
|
The E2E test failures here aren't consistent so I'm taking it to be CI failures; I've re-run them for over an hour without a successful run, but most runs are different so I'm merging… |
tofumatt
deleted the
issue/9181-implement-conversion-reporting-specific-internal-tracking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist