Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

google / site-kit-wp Public

Notifications You must be signed in to change notification settings
Fork 292
Star 1.3k

Code
Issues 503
Pull requests 71
Actions
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Wiki
Security
Insights

Enhancement/9889 Refactor RRM Setup CTA Banner#9938

Open

jimmymadon wants to merge 46 commits intodevelopgoogle/site-kit-wp:developfrom enhancement/9889-refactor-rrm-setup-cta-bannergoogle/site-kit-wp:enhancement/9889-refactor-rrm-setup-cta-bannerCopy head branch name to clipboard

+448-424

Conversation Commits46 (46)Checks Files changed

Commits

Commits on Dec 23, 2024

Remove rendering of WidgetNull.
jimmymadon
committed
Wrap RRM notification registration with a feature flag check.
jimmymadon
committed
Register RRM Setup CTA notification to the setup CTAs queue.
jimmymadon
committed
Remove direct rendering of RRM Setup CTA banner.
jimmymadon
committed
Move canActivateModule check to notification registration.
jimmymadon
committed
Refactor the RRM Setup CTA Component to use the new notification components.
jimmymadon
committed
Add propTypes and remove HOC.
jimmymadon
committed
Remove duplicated confirm GA tracking event.
jimmymadon
committed
Remove redundant dismissal logic and GA tracking view event.
jimmymadon
committed
Remove all common dismissal logic.
jimmymadon
committed
Fix incorrect title.
jimmymadon
committed
Add support to dismiss and redisplay a notification.
jimmymadon
committed
Check prompts and dismissed items to determine notification dismissal state.
jimmymadon
committed
Use new notification prompt dismissal in RRM CTA component.
jimmymadon
committed
Prevent notification from showing after tooltip is rendered.
jimmymadon
committed
Fix styles to match the legacy component.
jimmymadon
committed
Add the dismissRetries option to notification registration.
jimmymadon
committed
Use dismissRetries property from notification property instead of passing itto the action.
jimmymadon
committed
Move dismissRetries for RRM setup banner from react component to notification registration.
jimmymadon
committed
Only check for prompts if dismissRetries exists as a property.
jimmymadon
committed
Add a default value to dismissExpires to prevent undefined checks.
jimmymadon
committed
Improve notification dismissed selecter docs.
jimmymadon
committed
Add a selector to fetch if a notification is on its final retry.
jimmymadon
committed
Add support for multiple dismiss labels.
jimmymadon
committed
Fix undefined map select errors.
jimmymadon
committed

Commits on Dec 26, 2024

Move multiple dismiss labels out of common component.
jimmymadon
committed
Refactor breakpoint SVG rendering for RRM banner.
jimmymadon
committed
Refactor breakpoint SVG rendering for FPM banner.
jimmymadon
committed
Rename selector.
jimmymadon
committed
Check if notification isDismissible before checking number of retries.
jimmymadon
committed

Commits on Dec 28, 2024

Provide FPM notification data for isDismissed check.
jimmymadon
committed
Provide FPM Notification data for isDismissed check in Ads settings.
jimmymadon
committed
Separate out section of tests for isNotificationDismissed using dismissedItems.
jimmymadon
committed
Add tests for the isItemDismissed selector when using prompts.
jimmymadon
committed

Commits on Jan 2, 2025

Merge branch 'develop' into enhancement/9889-refactor-rrm-setup-cta-banner.
jimmymadon
committed
Update rendering of RRM notification component in JS tests.
jimmymadon
committed
Remove redundant trackEvent tests for RRM setup notification.
jimmymadon
committed
Update test description.
jimmymadon
committed
Refactor RRM notification registration to use an object of notifications for easier testing.
jimmymadon
committed
Fix onCTAClick test.
jimmymadon
committed

Commits on Jan 3, 2025

Prevent triggering survey when component is not rendered.
jimmymadon
committed
Fix all remaining tests for the RRM setup banner component.
jimmymadon
committed
Remove unnecessary use of view context when rendering the setup component.
jimmymadon
committed
Update dismissed key to use notification ID.
jimmymadon
committed
Update storybook.
jimmymadon
committed
Fix JSON response in test.
jimmymadon
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.