Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffectiveness Configurator settings #50

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove ineffectiveness Configurator settings #50

merged 1 commit into from
Jun 26, 2024

Conversation

ko1in1u
Copy link
Collaborator

@ko1in1u ko1in1u commented Jun 26, 2024

  • Timeout for action_acknowledgment, scroll_acknowledgment, and wait_for_selector have no effect on UiObject2.
  • Timeout for key_injection_delay is deprecated.

This change is Reviewable

- Timeout for `action_acknowledgment`, `scroll_acknowledgment`, and
`wait_for_selector` have no effect on UiObject2.
- Timeout for `key_injection_delay` is deprecated.
@ko1in1u ko1in1u added this to the 1.1.2 milestone Jun 26, 2024
@ko1in1u ko1in1u requested a review from eric100lin June 26, 2024 01:11
@ko1in1u ko1in1u self-assigned this Jun 26, 2024
Copy link
Collaborator

@eric100lin eric100lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ko1in1u)

@ko1in1u ko1in1u merged commit 4e881db into google:main Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants