-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gesture margin for default Scroll #51
Conversation
Please help to build and update apk here as well, thank you. |
Added .apk file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dshiroma and @ko1in1u)
snippet_uiautomator/android/app/src/main/java/com/google/android/mobly/snippet/uiautomator/UiObject2Snippet.java
line 313 at r3 (raw file):
throws SelectorException { Direction direction = Direction.valueOf(directionStr); UiObject2 uiObject2 = selector.toUiObject2();
nit: it would be nice to declare these variables as final
Suggestion:
final Direction direction = Direction.valueOf(directionStr);
final UiObject2 uiObject2 = selector.toUiObject2();
Done. |
Scroll
margin property to all RPC calls to scroll.Example usage now works as expected:
This change is