-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured zarr dtype as bytes #176
Open
brian-michell
wants to merge
46
commits into
google:master
Choose a base branch
from
brian-michell:Structured_zarr_as_bytes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Structured zarr dtype as bytes #176
brian-michell
wants to merge
46
commits into
google:master
from
brian-michell:Structured_zarr_as_bytes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata without field
…led as no field provided)
…ata without field
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tensorstore community. I have a project that requires the ability to open structured data as void #125. We accidentally submitted our hacky workaround #127 but received good feedback suggesting a pure Zarr driver update rather than editing the kvs_chunked_driver.
I've been working on an implementation to eventually submit back into mainline Tensorstore but I've run into some issues.
tensorstore/driver/driver.cc
. I hope this is simply my error in missing where it should be handled in the Zarr driver.tensorstore_driver_zarr_driver_test.cc:1151
.tensorstore_driver_zarr_dtype_test.cc
, which I would expect insinuates breaking changes to existing code using theZarrDType
class.I'm hoping to either get some advice on how to proceed or kick off the discussion for the more proper way to implement the behavior.
I also acknowledge the styling and naming conventions have not yet been followed and that the code is not yet optimal, my intent was to fix that upon a proper pull request.