Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dependencies group with 2 updates #1380

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2025

Bumps the dependencies group with 2 updates: org.gwtproject:gwt-user and org.gwtproject:gwt-dev.

Updates org.gwtproject:gwt-user from 2.11.0 to 2.12.1

Updates org.gwtproject:gwt-dev from 2.11.0 to 2.12.1

Updates org.gwtproject:gwt-dev from 2.11.0 to 2.12.1

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 6, 2025
@cpovirk
Copy link
Member

cpovirk commented Jan 6, 2025

@dependabot ignore org.gwtproject:gwt-user
@dependabot ignore org.gwtproject:gwt-dev

We can't do this at the moment for at least two reasons:

  • GWT 2.12.1 (and I think anything higher than 2.11.0) requires Maven to be run under Java 11. Our Java 8 CI job currently uses Java 8 even for Maven itself, rather than using a newer version for Maven and then using Java 8 to run tests. We could change that, as in Mess around more with Javadoc and Maven toolchains: guava#7591, but I'm not sure it's worth it, especially when Truth might end up being a guinea pig for a migration off Maven. (This is the problem that causes the CI failure that happened during this run.)
  • Even under Java 11+, we have another problem because of the mismatch between the guava-android bytecode and the guava-jre GWT sources (as noted in Decouple the version of GWT from the version of the GWT Maven Plugin, and bump GWT. #1378). That could probably be solved by separating out the Truth tests into their own submodule (as we do for Guava) or in other ways. But again, it's hard to get excited about doing anything about this.

@cpovirk
Copy link
Member

cpovirk commented Jan 7, 2025

@dependabot ignore org.gwtproject:gwt-user

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2025

OK, I won't notify you about org.gwtproject:gwt-user again, unless you unignore it.

Bumps the dependencies group with 2 updates: org.gwtproject:gwt-user and org.gwtproject:gwt-dev.


Updates `org.gwtproject:gwt-user` from 2.11.0 to 2.12.1

Updates `org.gwtproject:gwt-dev` from 2.11.0 to 2.12.1

Updates `org.gwtproject:gwt-dev` from 2.11.0 to 2.12.1

---
updated-dependencies:
- dependency-name: org.gwtproject:gwt-user
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.gwtproject:gwt-dev
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.gwtproject:gwt-dev
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-16a9230314 branch from 62e45d4 to 89d84d2 Compare January 7, 2025 13:47
@cpovirk
Copy link
Member

cpovirk commented Jan 7, 2025

@dependabot ignore org.gwtproject:gwt-dev

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2025

OK, I won't notify you about org.gwtproject:gwt-dev again, unless you unignore it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2025

Looks like these dependencies are no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Jan 7, 2025
@dependabot dependabot bot deleted the dependabot/maven/dependencies-16a9230314 branch January 7, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant