Add flags to control alignment steps #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, I am opening this PR that adds two flags to control whether global alignment and (local) fine realignment should run. Allowing to switch off the alignment steps for cases that do not need it can be an important optimization in terms of run time.
In our use cases the reference and degraded signals do not have any inter-frame lags, so omitting the fine realignment step and setting the search window to zero provides more than 3x faster runs.
The proposed changes include:
disable_global_alignment
flag, that skips theAlignment::GloballyAlign()
call and sets the global lag to 0.0disable_realignment
flag, that skips theComparisonPatchesSelector::FinelyAlignAndRecreatePatches()
call