Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Conversation

xLuis190
Copy link

No description provided.

Luis Felipe Jimenez Ferreira added 2 commits December 28, 2016 00:25
Added smooth scroll on the main page
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Garbee
Copy link
Contributor

Garbee commented Dec 28, 2016

What problem is this solving?

Why did you solve the problem the way you did?

Why require jQuery just for this plugin when there are a few vanilla JS alternatives that don't need so much extra code pulled in?

Please provide some details with merge requests to projects. This will help the maintainers understand what you are trying to change and why.

Thank you.

@QWp6t
Copy link

QWp6t commented Dec 28, 2016

lol @Garbee holster your pistol cowboy. It's prob just an accidental PR. Happens all the time man.

@Garbee
Copy link
Contributor

Garbee commented Dec 28, 2016

Assuming it isn't that information is useful. If it is accidental, then they can easily mention that and close the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants