Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Unity build pipeline #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raldred
Copy link

@raldred raldred commented Sep 16, 2016

Support the new Unity build pipeline using PostProcessBuildAttribute
Removed old shell scripts and implemented new c# script to automate adding of frameworks to xcode project using the new xcode tools provided by unity as part of the UnityEditor.iOS.Xcode namespace.

The old PostProcessBuildPlayer_GA & mod_pbxproj.py scripts are not longer necessary or supported.

Added new build pipeline script to automate the adding of iOS frameworks to the xcode project
The old shell script and python scripts are no longer required, Unity now comes with xcode tools on the UnityEditor.iOS.Xcode namespace
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@raldred
Copy link
Author

raldred commented Sep 16, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

using UnityEngine;
using UnityEditor;
using UnityEditor.Callbacks;
using UnityEditor.iOS.Xcode;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace UnityEditor.iOS.Xcode is define in "unityEditor.iOS.Extensions.xcode.dll" which is only installed when you also have IOSSupport playbackEngine installed. So you will want to add #if UNITY_IOS guards.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies you're right. I will correct it asap.

@3ace
Copy link

3ace commented May 8, 2017

I'm using Xcode 8.3.2 and latest iOS SDK.

Using this script, libz.dylib and libsqlite3.tbd would link to the wrong directory

/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.3.sdk/System/Library/Frameworks

the correct path should be

/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.3.sdk/usr/lib/

And libz.dylib no longer exist, replaced by libz.tbd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants