Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add two optional to required fields on dialogflow #723

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Hectorhammett
Copy link
Contributor

Related:
googleapis/google-cloud-php#7579

Add an fix to the Dialogflow SearchKnowledgeRequest by reverting them to optional after the API made a breaking change changing two fields to mandatory when before were optional.

@Hectorhammett Hectorhammett requested a review from bshaffer August 8, 2024 19:44
@Hectorhammett Hectorhammett requested review from a team as code owners August 8, 2024 19:44
@bshaffer bshaffer merged commit 307d871 into main Aug 8, 2024
4 checks passed
@bshaffer bshaffer deleted the dialogflow-fix branch August 8, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants