feat: Add union type to support the ClientOptions class in the client constructor #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
reviewed
Aug 27, 2024
| @@ -72,6 +72,7 @@ private function generateImpl(): PhpFile | |||
| { | |||
| // TODO(vNext): Remove the forced addition of these `use` clauses. | |||
| $this->ctx->type(Type::fromName(\Google\ApiCore\PathTemplate::class)); | |||
| $this->ctx->type(Type::fromName(\Google\ApiCore\Options\ClientOptions::class)); | |||
There was a problem hiding this comment.
this should probably go in private function construct(), to keep it together with the function it goes with below
There was a problem hiding this comment.
I can see what you mean, my thought was to match 1 to 1 how does this gets placed in the generated file. For example, due finding Google\ApiCore\PathTemplate on the generated file, I was able to determine how this gets added.
Still, I am not completely opposed to moving it to another place.
bshaffer
reviewed
Sep 10, 2024
| @@ -333,7 +334,7 @@ public static function parseName(string $formattedName, string $template = null) | |||
| * | |||
| * @throws ValidationException | |||
| */ | |||
| public function __construct(array $options = []) | |||
| public function __construct(array|ClientOptions $options = []) | |||
| { | |||
| $clientOptions = $this->buildClientOptions($options); | |||
There was a problem hiding this comment.
As buildClientOptions doesn't support ClientOptions, we'll need to update this in GAX (this is somewhat handled in googleapis/gax-php#580, but should probably be separated from the changes to make the properties public).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.