Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrap certain grpc errors #810

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

viacheslav-rostovtsev
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev commented Aug 19, 2022

  • Reclassifies ::GRPC::Unavailable errors that contain Signet::AuthorizationError into Gapic::GRPC::AuthorizationError which is derived from ::GRPC::Unauthenticated
  • If an exception led to a retry, and then a deadline was exceeded, when ::GRPC::DeadlineExceeded was thrown, it gets wrapped into the Gapic::GRPC::DeadlineExceededError which inherits from ::GRPC::DeadlineExceeded but contains additional information about the retried exception.

Related to and will fix: googleads/google-ads-ruby#246.

Internal re: go/cloudclibs-ruby-unavailable-auth

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 19, 2022
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable so far.

gapic-common/lib/gapic/grpc/errors.rb Outdated Show resolved Hide resolved
gapic-common/lib/gapic/grpc/errors.rb Outdated Show resolved Hide resolved
gapic-common/lib/gapic/grpc/errors.rb Outdated Show resolved Hide resolved
gapic-common/lib/gapic/grpc/errors.rb Outdated Show resolved Hide resolved
@viacheslav-rostovtsev viacheslav-rostovtsev force-pushed the dev/virost/misc/auth_error_design branch 4 times, most recently from fa24095 to 6be5f20 Compare September 3, 2022 00:21
@viacheslav-rostovtsev viacheslav-rostovtsev marked this pull request as ready for review September 3, 2022 00:22
@viacheslav-rostovtsev viacheslav-rostovtsev requested a review from a team as a code owner September 3, 2022 00:22
@viacheslav-rostovtsev viacheslav-rostovtsev changed the title sample: error design feat: rewrap certain grpc errors Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling list_accessible_customers with invalid refresh_token retries forever
2 participants