-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrap certain grpc errors #810
Merged
viacheslav-rostovtsev
merged 4 commits into
main
from
dev/virost/misc/auth_error_design
Sep 15, 2022
Merged
feat: rewrap certain grpc errors #810
viacheslav-rostovtsev
merged 4 commits into
main
from
dev/virost/misc/auth_error_design
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Aug 19, 2022
dazuma
reviewed
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable so far.
viacheslav-rostovtsev
force-pushed
the
dev/virost/misc/auth_error_design
branch
4 times, most recently
from
September 3, 2022 00:21
fa24095
to
6be5f20
Compare
viacheslav-rostovtsev
changed the title
sample: error design
feat: rewrap certain grpc errors
Sep 3, 2022
dazuma
approved these changes
Sep 6, 2022
dazuma
approved these changes
Sep 14, 2022
viacheslav-rostovtsev
force-pushed
the
dev/virost/misc/auth_error_design
branch
from
September 14, 2022 20:28
a76effa
to
72b20e5
Compare
viacheslav-rostovtsev
force-pushed
the
dev/virost/misc/auth_error_design
branch
from
September 14, 2022 21:07
72b20e5
to
a70a9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::GRPC::Unavailable
errors that containSignet::AuthorizationError
intoGapic::GRPC::AuthorizationError
which is derived from::GRPC::Unauthenticated
::GRPC::DeadlineExceeded
was thrown, it gets wrapped into theGapic::GRPC::DeadlineExceededError
which inherits from::GRPC::DeadlineExceeded
but contains additional information about the retried exception.Related to and will fix: googleads/google-ads-ruby#246.
Internal re: go/cloudclibs-ruby-unavailable-auth