Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BaseClientService.UniverDomain setter is obsolete. #2870

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: BaseClientService.UniverDomain setter is obsolete. #2870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Src/Support/Google.Apis/Services/BaseClientService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ protected BaseClientService(Initializer initializer)
ApiKey = initializer.ApiKey;
ApplicationName = initializer.ApplicationName;
BaseUriOverride = initializer.BaseUri;
#pragma warning disable CS0618 // We still need to initialize the value on construction but the setter is rightly obsolete.
UniverseDomain = initializer.UniverseDomain;
#pragma warning restore CS0618 // Type or member is obsolete
HttpClientTimeout = initializer.HttpClientTimeout;
ValidateParameters = initializer.ValidateParameters;
if (ApplicationName == null)
Expand Down Expand Up @@ -220,7 +222,14 @@ protected BaseClientService(Initializer initializer)
/// is set, in which case <see cref="BaseUriOverride"/> will be used without further modification.
/// </para>
/// </remarks>
public string UniverseDomain { get; set; }
public string UniverseDomain
{
get;
[Obsolete(
"Using this setter never had any effect, the UniverseDomain value is used on Client construction only. " +
"Build a new Client specifying a new universe domain value instead.")]
set;
}

/// <summary>
/// The timeout to set on <see cref="HttpClient"/> instances used by the service.
Expand Down