Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pad base64 strings for base64js #722

Merged
merged 4 commits into from
May 29, 2019

Conversation

alexander-fenster
Copy link
Contributor

Fixes #716. Also, adding tests for both crypto implementations.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #722 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #722     +/-   ##
=========================================
- Coverage   84.78%   84.69%   -0.1%     
=========================================
  Files          18       18             
  Lines         940      941      +1     
  Branches      209      209             
=========================================
  Hits          797      797             
- Misses         83       84      +1     
  Partials       60       60
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <ø> (ø) ⬆️
src/crypto/browser/crypto.ts 10% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53acfb...ed5c079. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #722 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #722     +/-   ##
=========================================
- Coverage   84.78%   84.69%   -0.1%     
=========================================
  Files          18       18             
  Lines         940      941      +1     
  Branches      209      209             
=========================================
  Hits          797      797             
- Misses         83       84      +1     
  Partials       60       60
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <ø> (ø) ⬆️
src/crypto/browser/crypto.ts 10% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53acfb...5759fdb. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 81e0a23 into master May 29, 2019
@alexander-fenster alexander-fenster deleted the pad-base64-test-crypto branch May 29, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser/crypto base64 decoding strictly required padding
3 participants