Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metadata timeout more accessible and controlleable for AppEngine stubs. #1518

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ludoch
Copy link

@ludoch ludoch commented Apr 12, 2024

No description provided.

@ludoch ludoch requested review from a team as code owners April 12, 2024 20:54
@ludoch ludoch changed the title Add missing env var Make metadata timeout more accessible and controlleable for AppEngine stubs. Apr 12, 2024
Copy link
Contributor

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request!

Could you add a chore: prefix to your commit message like chore: make metadata...?

There are also a few kokoro build failures.
(1) lint failure. You can run python -m nox -s blacken to format the files, then python -m nox -s lint to verify.
(2) unit test failures - METADATA_HEADERS instead of METADATA_HEADER
(3) after the unit test code is fixed, please run python -m nox -s cover to see if all tests and the coverage check can pass (this repo requires 100% code coverage)

Thanks!

@@ -105,8 +105,45 @@ def test_ping_success(mock_metrics_header_value):
request.assert_called_once_with(
method="GET",
url=_metadata._METADATA_IP_ROOT,
headers=MDS_PING_REQUEST_HEADER,
timeout=_metadata._METADATA_DEFAULT_TIMEOUT,
headers=_metadata._METADATA_HEADER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_METADATA_HEADERS

request.assert_called_once_with(
method="GET",
url=_metadata._METADATA_IP_ROOT,
headers=_metadata._METADATA_HEADER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_METADATA_HEADERS

@arithmetic1728
Copy link
Contributor

Looks like you have an older PR for this as well, #1481. Should we close that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants