test(bigtable): Fix conformance test TestReadRows_NoRetry_ErrorAfterLastRow #10213
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
|
@bhshkh is this still wanted/needed? |
bhshkh
changed the title
Yes |
mutianf
reviewed
Dec 11, 2024
| rowsToRead = int64(req.GetCancelAfterRows()) | ||
| } | ||
|
|
||
| // Client libray does not have a built-in way to limit the number of rows read in a call to Table.ReadRows(). |
There was a problem hiding this comment.
This is not ideal, is this a limitation with go? the proto should allow us to set the row limit, and the client should track how many rows are read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking bug: b/303943537
This PR fixes TestReadRows_Retry_LastScannedRow_Reverse test
https://github.com/googleapis/cloud-bigtable-clients-test/blob/db4d6a9e8e5e38b6f07383bd46ac14bfc8d8b9b6/tests/readrows_test.go#L171-L173
fails with error:
The test sends below request to Go Bigtable proxy:
On receiving the request, the proxy creates a ReadRows request for the client library and invokes ReadRows function.
Even though test sends RowsLimit field in the method, the proxy does not add it to the client library request. This has been fixed in this PR.