Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub/pstest): support listening on custom address #11606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larryanz
Copy link
Contributor

Regarding #11569, this PR adds support of pstest test server to listening on custom hosts rather than only localhost.

Due to CI running issue, this is the second part of the changes. Which only includes changes of pstest.
Part 1 is #11586

@larryanz larryanz requested review from shollyman and a team as code owners February 19, 2025 03:24
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 19, 2025
@larryanz larryanz force-pushed the feat/ps-fake-support-listening-custom-address branch from c8a11b5 to e4392b8 Compare February 21, 2025 02:48
@larryanz
Copy link
Contributor Author

hi @hongalex please help to take a look

@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2025
@larryanz larryanz force-pushed the feat/ps-fake-support-listening-custom-address branch from a21229e to 45bad5d Compare February 25, 2025 03:41
@larryanz
Copy link
Contributor Author

larryanz commented Feb 25, 2025

It seems ci uni tests failed caused by some code outdates. I have just rebased the branch and double check it on my local. please help to run ci again, thanks @hongalex , this feature is important to me now.
https://btx.cloud.google.com/invocations/fbe78021-caac-4695-9f2a-27a3c7c2aea0/log

go: downloading cloud.google.com/go/longrunning v0.6.4
# cloud.google.com/go/pubsub/pstest
pstest/fake.go:139:23: undefined: testutil.NewServerWithAddress
FAIL	cloud.google.com/go/pubsub [build failed]
?   	cloud.google.com/go/pubsub/apiv1/pubsubpb	[no test files]
?   	cloud.google.com/go/pubsub/internal	[no test files]
?   	cloud.google.com/go/pubsub/internal/benchwrapper	[no test files]
?   	cloud.google.com/go/pubsub/internal/benchwrapper/proto	[no test files]
=== RUN   TestPublisherSmoke

@larryanz larryanz force-pushed the feat/ps-fake-support-listening-custom-address branch from 45bad5d to 9de605c Compare February 26, 2025 03:27
@hongalex hongalex enabled auto-merge (squash) February 27, 2025 02:29
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 27, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 27, 2025
@larryanz
Copy link
Contributor Author

something weird here, in codebase we already rebased the code onto main, then we already have the method testutil.NewServerWithAddress, then why the ci continues to fail
image

@hongalex
Copy link
Member

This is likely waiting on the new release of cloud.google.com/go. I don't see a release where your previous PR got included though. @quartzmo can you confirm how we can get #11586 in a release?

auto-merge was automatically disabled February 27, 2025 06:36

Head branch was pushed to by a user without write access

@larryanz larryanz force-pushed the feat/ps-fake-support-listening-custom-address branch from e5af16c to c6af3d1 Compare February 27, 2025 06:36
@larryanz larryanz requested review from a team as code owners February 27, 2025 06:36
@larryanz larryanz force-pushed the feat/ps-fake-support-listening-custom-address branch from c6af3d1 to cb6526f Compare February 27, 2025 06:38
@hongalex hongalex removed request for a team February 27, 2025 06:38
@hongalex hongalex requested review from quartzmo and removed request for a team February 27, 2025 06:38
@hongalex
Copy link
Member

@quartzmo will take a look at this next week when the next release triggers

@larryanz
Copy link
Contributor Author

May I ask for the release cycle? In the docs i saw that the lib will be released automatically, but for testutil you said we have it in weekly cycle, then for pubsub/pstest, when we will have it @hongalex ?

@hongalex
Copy link
Member

This PR is currently blocked until the testutil changes you made in the other PR is part of some release. There may be an issue but I'm not sure when it will trigger, and when I spoke to @quartzmo he said he can take a look next week.

After that lands, we would upgrade the cloud.google.com/go version in pubsub/go.mod which should make the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants