-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub/pstest): support listening on custom address #11606
base: main
Are you sure you want to change the base?
feat(pubsub/pstest): support listening on custom address #11606
Conversation
c8a11b5
to
e4392b8
Compare
hi @hongalex please help to take a look |
a21229e
to
45bad5d
Compare
It seems ci uni tests failed caused by some code outdates. I have just rebased the branch and double check it on my local. please help to run ci again, thanks @hongalex , this feature is important to me now. go: downloading cloud.google.com/go/longrunning v0.6.4
# cloud.google.com/go/pubsub/pstest
pstest/fake.go:139:23: undefined: testutil.NewServerWithAddress
FAIL cloud.google.com/go/pubsub [build failed]
? cloud.google.com/go/pubsub/apiv1/pubsubpb [no test files]
? cloud.google.com/go/pubsub/internal [no test files]
? cloud.google.com/go/pubsub/internal/benchwrapper [no test files]
? cloud.google.com/go/pubsub/internal/benchwrapper/proto [no test files]
=== RUN TestPublisherSmoke |
45bad5d
to
9de605c
Compare
Head branch was pushed to by a user without write access
e5af16c
to
c6af3d1
Compare
c6af3d1
to
cb6526f
Compare
@quartzmo will take a look at this next week when the next release triggers |
May I ask for the release cycle? In the docs i saw that the lib will be released automatically, but for |
This PR is currently blocked until the testutil changes you made in the other PR is part of some release. There may be an issue but I'm not sure when it will trigger, and when I spoke to @quartzmo he said he can take a look next week. After that lands, we would upgrade the |
Regarding #11569, this PR adds support of pstest test server to listening on custom hosts rather than only localhost.
Due to CI running issue, this is the second part of the changes. Which only includes changes of pstest.
Part 1 is #11586