Fix PHP style checks

Datastore/src/Operation.php

@@ -459,7 +459,13 @@ public function lookup(array $keys, array $options = [])
             $serviceKeys[] = $key->keyObject();
         });
 
-        list($data, $optionalArgs) = $this->splitOptionalArgs($options, ['transaction', 'className', 'sort', 'readTime', 'readConsistency']);
+        list($data, $optionalArgs) = $this->splitOptionalArgs($options, [
+            'transaction',
+            'className',
+            'sort',
+            'readTime',
+            'readConsistency'
+        ]);
         $data += $this->readOptions($options) + [
             'projectId' => $this->projectId,
             'databaseId' => $this->databaseId,
@@ -748,15 +754,15 @@ public function commit(array $mutations, array $options = [])
             $data = $mutation[$mutationType];
             if (isset($data['properties'])) {
                 foreach ($data['properties'] as &$property) {
-                    list ($type, $val) = $this->toGrpcValue($property);
+                    list($type, $val) = $this->toGrpcValue($property);
 
                     $property[$type] = $val;
                 }
             }
 
             $mutation[$mutationType] = $data;
 
-            $mutation = $this->serializer->decodeMessage(new Mutation, $mutation);
+            $mutation = $this->serializer->decodeMessage(new Mutation(), $mutation);
         }
 
         $options += [
@@ -1104,7 +1110,7 @@ private function parseQuery(array $query)
         }
 
         $parsedQuery = $this->serializer->decodeMessage(
-            new V1Query,
+            new V1Query(),
             $query
         );
         return $parsedQuery;
@@ -1139,7 +1145,7 @@ private function parseGqlQuery(array $gqlQuery)
         }
 
         $parsedGqlQuery = $this->serializer->decodeMessage(
-            new GqlQuery,
+            new GqlQuery(),
             $gqlQuery
         );
 
@@ -1198,7 +1204,7 @@ private function prepareQueryBinding(array $binding)
     {
         $value = $binding['value'];
 
-        list ($type, $val) = $this->toGrpcValue($value);
+        list($type, $val) = $this->toGrpcValue($value);
 
         $binding['value'][$type] = $val;
 

Datastore/tests/Snippet/ReadOnlyTransactionTest.php

@@ -104,7 +104,7 @@ public function testClass()
             0
         );
 
-        $this->refreshOperation($this->client,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->client, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -134,7 +134,7 @@ public function testClassRollback()
 
         $snippet = $this->snippetFromClass(ReadOnlyTransaction::class, 1);
 
-        $this->refreshOperation($this->client,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->client, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -175,7 +175,7 @@ public function testLookup()
             ]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -226,7 +226,7 @@ public function testLookupBatch()
             ]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -272,7 +272,7 @@ public function testRunQuery()
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -287,7 +287,7 @@ public function testRollback()
 
         $this->mockSendRequest('rollback', [], [], 0);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 

Datastore/tests/Snippet/TransactionTest.php

@@ -108,7 +108,7 @@ public function testClass()
             0
         );
 
-        $this->refreshOperation($this->client,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->client, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -132,7 +132,7 @@ public function testInsert()
             ]
         ]);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -153,7 +153,7 @@ public function testInsertBatch()
 
         $this->allocateIdsRequestHandlerMock();
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -175,7 +175,7 @@ public function testUpdate()
             ]
         ]);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -212,7 +212,7 @@ public function testUpsert()
             ]
         ]);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -246,7 +246,7 @@ public function testDelete()
             ]
         ]);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -293,7 +293,7 @@ public function testLookup()
             ]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -344,7 +344,7 @@ public function testLookupBatch()
             ]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -390,7 +390,7 @@ public function testRunQuery()
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -426,7 +426,7 @@ public function testRunAggregationQuery()
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -441,7 +441,7 @@ public function testCommit()
 
         $this->mockSendRequest('commit', [], [], 0);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -455,7 +455,7 @@ public function testRollback()
 
         $this->mockSendRequest('rollback', [], [], 0);
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 

Datastore/tests/Unit/OperationTest.php

@@ -666,7 +666,9 @@ public function testRunQueryWithoutReadOptions()
         $this->requestHandler->sendRequest(
             DatastoreClient::class,
             'runQuery',
-            Argument::that(function ($req) {return !$req->hasReadOptions();}),
+            Argument::that(function ($req) {
+                return !$req->hasReadOptions();
+            }),
             Argument::cetera()
         )->willReturn([])->shouldBeCalled();
 
@@ -862,7 +864,7 @@ public function testMutateWithKey()
         $this->requestHandler->sendRequest(
             DatastoreClient::class,
             'commit',
-            Argument::that(function ($arg) use ($otherThis){
+            Argument::that(function ($arg) use ($otherThis) {
                 $data = $otherThis->serializer->encodeMessage($arg);
                 $x = isset($data['mutations'][0]['delete']['path']);
                 return isset($data['mutations'][0]['delete']['path']);

Datastore/tests/Unit/TransactionTest.php

@@ -123,7 +123,7 @@ public function testLookup(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -151,7 +151,7 @@ public function testLookupMissing(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -186,7 +186,7 @@ public function testLookupBatch(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -216,7 +216,7 @@ public function testLookupBatchWithReadTime(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -247,7 +247,7 @@ public function testRunQuery(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -284,7 +284,7 @@ public function testRunAggregationQuery(callable $transaction)
         );
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -323,7 +323,7 @@ public function testRunQueryWithReadTime()
         );
 
         $transaction = $this->readOnly;
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -343,7 +343,7 @@ public function testRollback(callable $transaction)
         $this->mockSendRequest('rollback', ['transaction' => self::TRANSACTION], [], 0);
 
         $transaction = $transaction();
-        $this->refreshOperation($transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -366,7 +366,7 @@ public function testEntityMutations($method, $mutation, $key)
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -392,7 +392,7 @@ public function testEntityMutationsBatch($method, $mutation, $key)
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -433,7 +433,7 @@ public function testMutationsWithPartialKey($method, $mutation, $key, $id)
             ['keys' => [$keyWithId->keyObject()]]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -468,7 +468,7 @@ public function testBatchMutationsWithPartialKey($method, $mutation, $key, $id)
             ['keys' => [$keyWithId->keyObject()]]
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -501,7 +501,7 @@ public function testDelete()
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);
 
@@ -525,7 +525,7 @@ public function testDeleteBatch()
             0
         );
 
-        $this->refreshOperation($this->transaction,$this->requestHandler->reveal(), [
+        $this->refreshOperation($this->transaction, $this->requestHandler->reveal(), [
             'projectId' => self::PROJECT
         ]);