Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky tracing test. #2245

Merged
merged 1 commit into from
Dec 3, 2024
Merged

test: fix flaky tracing test. #2245

merged 1 commit into from
Dec 3, 2024
+10 −1

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Dec 3, 2024

Fixes #2244.

@ehsannas ehsannas requested review from a team as code owners December 3, 2024 02:10
@ehsannas ehsannas self-assigned this Dec 3, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Dec 3, 2024
@ehsannas
Copy link
Contributor Author

ehsannas commented Dec 3, 2024

The following test has failed:

  1) Aggregation queries
       Aggregation queries - sum / average using aggregate() api
         performs average of min IEEE754:

I'll rerun the integration tests.

@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Dec 3, 2024
@MarkDuckworth MarkDuckworth merged commit fda53d2 into main Dec 3, 2024
17 checks passed
@MarkDuckworth MarkDuckworth deleted the ehsann/fix-tracing-test branch December 3, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing Flaky test
3 participants
@ehsannas @MarkDuckworth @yoshi-kokoro