Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for audioTimestamp in GenerationConfig #467

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jayhickey
Copy link
Contributor

@jayhickey jayhickey commented Nov 15, 2024

Adding support for the audioTimestamp to the GenerationConfig. This is already supported in the Python SDK and the documentation references it:

The following shows you how to use an audio file to transcribe an interview. To enable timestamp understanding for audio-only files, enable the audioTimestamp parameter in GenerationConfig.

Copy link

google-cla bot commented Nov 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Nov 15, 2024
@jayhickey jayhickey changed the title Add support for audioTimestamp in GenerationConfig feat: add support for audioTimestamp in GenerationConfig Nov 15, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@timconnorz
Copy link

Would love to see this merged! we really need it!!

@jayhickey
Copy link
Contributor Author

Could I get some eyes on this please? 🙏

cc @pavelgj @yyyu-google @happy-qiao if any of you are able to review?

@yyyu-google yyyu-google self-assigned this Nov 25, 2024
@yyyu-google yyyu-google merged commit 598d955 into googleapis:main Nov 26, 2024
5 checks passed
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
… Vertex SDK

FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700154603
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
… Vertex SDK

FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700154603
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
… Vertex SDK

FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700154603
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
… Vertex SDK

FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700154603
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
… Vertex SDK

FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700154603
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700198221
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700198221
copybara-service bot pushed a commit that referenced this pull request Nov 26, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#467 from jayhickey:jay/audio-timestamp 1b482ef
PiperOrigin-RevId: 700198221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants