-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for audioTimestamp in GenerationConfig #467
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
d184378
to
1b482ef
Compare
Would love to see this merged! we really need it!! |
Could I get some eyes on this please? 🙏 cc @pavelgj @yyyu-google @happy-qiao if any of you are able to review? |
Adding support for the
audioTimestamp
to the GenerationConfig. This is already supported in the Python SDK and the documentation references it: