feat: add support for python 3.13 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
|
parthea
added
the
status: blocked
parthea
removed
the
status: blocked
parthea
force-pushed
the
add-python-313
branch
from
ddf7bd0
to
cb279c9
Compare
…-api-core into add-python-313
ohmayr
approved these changes
Oct 15, 2024
| @@ -95,7 +95,8 @@ def install_prerelease_dependencies(session, constraints_path): | |||
| prerel_deps = [ | |||
| "google-auth", | |||
| "googleapis-common-protos", | |||
| "grpcio", | |||
| # Exclude grpcio!=1.67.0rc1 which does not support python 3.13 | |||
There was a problem hiding this comment.
Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.
There was a problem hiding this comment.
Without this change, the pre-release test fails (See https://github.com/googleapis/python-api-core/actions/runs/11259852849/job/31309789274)
Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.
We don't get the stable version in the prerelease_deps nox session. We get the latest pre-release which is https://pypi.org/project/grpcio/1.67.0rc1/. We're not disabling all rc versions, just 1.67.0rc1 which doesn't support python 3.13
Co-authored-by: ohmayr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695 🦕