Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support data split for evaluation in linear and ensemble models #1081

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: support data split for evaluation in linear and ensemble models #1081

wants to merge 8 commits into from

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 14, 2024 •
edited
Loading

This will allow the evaluation data part of the model info (in BigQuery Studio UI or REST API) carry more meaningful evaluation metrics.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated:
    • LinearRegression: screen/33pQ7ibEAwUrSbG, screen/4CPe8npW9jbanct
    • LogisticRegression: screen/eiSVxXDkbcidTDt, screen/AqsbmYregnTBe9n
    • XGBRegressor: screen/3RkffspWtouJTHY, screen/5qMK4upPNwkE5UT
    • XGBClassifier: screen/A5ZZgv9nYyNxRoB, screen/8ggP4a8jkCnh7z9
    • RandomForestRegressor: screen/9rF8iZU8PdK6TMz, screen/73PNPN75SGiQjAs
    • RandomForestClassifier: screen/4cgHQabDKVLVbVG, screen/5czytszb62VetFK

Fixes internal issue 372344226 🦕

@shobsi shobsi requested review from a team as code owners October 14, 2024 09:34
@shobsi shobsi requested a review from GarrettWu October 14, 2024 09:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 14, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 15, 2024
@shobsi shobsi changed the title feat: support data split method in LinearRegression feat: support data split for evaluation in linear and ensemble models Oct 15, 2024
@shobsi shobsi requested a review from TrevorBergeron October 15, 2024 16:48
@shobsi shobsi removed the request for review from TrevorBergeron October 15, 2024 23:33
@shobsi shobsi marked this pull request as draft October 15, 2024 23:33
@shobsi shobsi mentioned this pull request Nov 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

At least 1 approving review is required to merge this pull request.

Assignees

@jiaxunwu jiaxunwu

@mattyopl mattyopl

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @jiaxunwu @mattyopl