Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Enable reading JSON data with dbjson extension dtype #1139

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 377764399 🦕

@chelsea-lin chelsea-lin requested a review from tswast November 7, 2024 21:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 7, 2024
@chelsea-lin chelsea-lin changed the title feat: Enable reading/writing JSON data with dbjson extension dtype feat: Enable reading JSON data with dbjson extension dtype Nov 7, 2024
@tswast tswast changed the title feat: Enable reading JSON data with dbjson extension dtype feat!: Enable reading JSON data with dbjson extension dtype Nov 8, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Let's make sure we mark this as a "breaking change" in our release notes (https://github.com/googleapis/release-please/blob/main/README.md#how-should-i-write-my-commits)

Since it's a breaking change for a preview feature, we shouldn't bump to 2.0 though. Let's use the Release-As footer in the commit message to make sure we do a 1.x release. https://github.com/googleapis/release-please/blob/main/README.md#how-do-i-change-the-version-number

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_readdbjsontype branch from 7c81975 to 48ca926 Compare November 13, 2024 19:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants