perf: Prevent deferring filters with remote functions #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tswast
reviewed
Dec 27, 2024
|
|
||
| # Remote ops are expensive so force reprojection before to ensure filters get applied first | ||
| any_remote_op = any( | ||
| ex.contains_op(expr, bigframes.operations.RemoteFunctionOp) |
There was a problem hiding this comment.
I'm a little bit concerned about hard coding remote function op here. Would it be better to flag each scalar operator as "expensive" / "cheap"?
Certainly there's a spectrum of costs possible, but a distinction could be made if there's an associated cost (e.g. cloud run CPU in this case) per call.
For example, LLM-style ops, BQML prediction (though that's not a scalar in BigQuery terms, though maybe could be in Bigframes eventually), could similarly have an "there's an extra cost associated here" flag.
|
Instead, removing all filter deferment in #1336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕