perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget #1937
+128
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
aee37a7 to
303c4af
Compare
tswast
reviewed
Jul 25, 2025
Comment on lines
+79
to
+86
| # Access total_rows through type casting (internal use only) | ||
| from bigframes.core.blocks import PandasBatches | ||
|
|
||
| if isinstance(self._batches, PandasBatches): | ||
| self.row_count = self._batches.total_rows or 0 | ||
| else: | ||
| # Fallback for compatibility | ||
| self.row_count = 0 |
There was a problem hiding this comment.
Why do you need this? to_pandas_batches is implemented in this package. We shouldn't have to protect against that.
There was a problem hiding this comment.
I recommend using the cast method, if this is just for the type checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget