Skip to content

Commit

Permalink
feat: find emulator project id from environment variable
Browse files Browse the repository at this point in the history
Previously, if `FIRESTORE_EMULATOR_HOST` was set and a `Client` instance was created without an explicit project, it would fall-back to `google-cloud-firestore-emulator`

This change makes it check the `GCLOUD_PROJECT` variable for a project id first, which is used by the firebase functions emulator. This means the client will auto-detect the project id if not given in the emulator, just like in a live GCP environment

Fixes firebase/firebase-functions-python#174
  • Loading branch information
daniel-sanche authored Feb 16, 2024
1 parent 6cb3147 commit eb454f1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion google/cloud/firestore_v1/base_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def __init__(
if credentials is None:
credentials = AnonymousCredentials()
if project is None:
project = _DEFAULT_EMULATOR_PROJECT
# extract project from env var, or use system default
project = os.getenv("GCLOUD_PROJECT", _DEFAULT_EMULATOR_PROJECT)

super(BaseClient, self).__init__(
project=project,
Expand Down

0 comments on commit eb454f1

Please sign in to comment.