-
Notifications
You must be signed in to change notification settings - Fork 80
feat: add primary pipeline stages #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniel-sanche
wants to merge
189
commits into
pipeline_queries_approved
Choose a base branch
from
pipeline_queries_3_stable_stages
base: pipeline_queries_approved
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add primary pipeline stages #1048
daniel-sanche
wants to merge
189
commits into
pipeline_queries_approved
from
pipeline_queries_3_stable_stages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 3cd826b Author: Daniel Sanche <[email protected]> Date: Thu Jun 12 12:45:46 2025 -0700 fixed lint commit bf0dca2 Author: Daniel Sanche <[email protected]> Date: Thu Jun 12 12:35:28 2025 -0700 fixed repr test commit c62e448 Author: Daniel Sanche <[email protected]> Date: Thu Jun 12 12:35:17 2025 -0700 add pipeline() method to collections commit 38f00a7 Author: Daniel Sanche <[email protected]> Date: Tue Jun 10 16:29:02 2025 -0700 ran black commit b2546f7 Author: Daniel Sanche <[email protected]> Date: Tue Jun 10 16:26:45 2025 -0700 use TEST_DATABASES list commit bf7adad Author: Daniel Sanche <[email protected]> Date: Tue Jun 10 16:07:58 2025 -0700 improved verify_pipeline check commit 74a5d22 Author: Daniel Sanche <[email protected]> Date: Mon Jun 9 16:36:16 2025 -0700 ran black
commit ad3e3df Author: Daniel Sanche <[email protected]> Date: Fri Jun 20 17:44:37 2025 -0700 added .pipeline() to aggregation query commit 4ce1b91 Author: Daniel Sanche <[email protected]> Date: Fri Jun 20 15:17:20 2025 -0700 added exprs and stages needed for aggregation pipelines commit e7d8e52 Merge: 0d15355 17e71b9 Author: Daniel Sanche <[email protected]> Date: Tue Jun 17 16:57:45 2025 -0700 Merge branch 'pipeline_queries_approved' into pipeline_queries_2_query_parity commit 17e71b9 Author: Daniel Sanche <[email protected]> Date: Tue Jun 17 15:54:31 2025 -0700 feat: add pipelines structure (#1046) commit 0d15355 Author: Daniel Sanche <[email protected]> Date: Tue Jun 17 15:52:38 2025 -0700 fixed tests commit bc25930 Merge: 6351ae7 13389b8 Author: Daniel Sanche <[email protected]> Date: Tue Jun 17 15:38:05 2025 -0700 Merge branch 'pipeline_queries_1_stubs' into pipeline_queries_2_query_parity commit 6351ae7 Author: Daniel Sanche <[email protected]> Date: Tue Jun 17 15:35:15 2025 -0700 merged PR #1 commit 13389b8 Author: Daniel Sanche <[email protected]> Date: Mon Jun 16 15:15:26 2025 -0700 fixed mypy commit 06a2084 Author: Daniel Sanche <[email protected]> Date: Mon Jun 16 14:57:54 2025 -0700 added generic_stage method to base_pipeline commit 8a9c3ec Author: Daniel Sanche <[email protected]> Date: Mon Jun 16 14:55:50 2025 -0700 made stages private commit a818f52 Author: Daniel Sanche <[email protected]> Date: Mon Jun 16 14:28:20 2025 -0700 removed converter reference commit e74e04d Author: Daniel Sanche <[email protected]> Date: Mon Jun 16 14:22:13 2025 -0700 added separate stream/execute methods commit 64cd4fb Author: Daniel Sanche <[email protected]> Date: Thu Jun 12 11:22:25 2025 -0700 fixed comment commit 3432322 Author: Daniel Sanche <[email protected]> Date: Tue Jun 10 17:03:09 2025 -0700 fixed lint
8df814c
to
f732f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the previous to add all currently supported additional stages and expressions
There are a lot of new files to review, but review should be fairly straightforward - just adding new
expression
andstage
subclasses as introduced previouslyThis PR also adds end to end testing through
test_pipeline_acceptance.py
, which runs test cases inpipelines_e2e.yaml