feat: declare typing for 'firestore_v1' and 'firestore_bundle' packages #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated tests in 'tests/unit/gapic/' are not yet mypy-safe.
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
tseaver
changed the title
tseaver
force-pushed
the
447-expand-mypy
branch
from
fd03104 to
a7273b9
Compare
tseaver
force-pushed
the
447-expand-mypy
branch
from
e77bb01 to
afe1793
Compare
|
Superseded by #507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test them, along with 'tests/' in the 'mypy' nox session.
Closes #447.