fix: allow circular deps

googleapis · Dec 12, 2024 · 0833c91 · 0833c91
1 parent 99c36a5
commit 0833c91
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/plugins/workspace.ts b/src/plugins/workspace.ts
@@ -447,9 +447,10 @@ export abstract class WorkspacePlugin<T> extends ManifestPlugin {
   ) {
     this.logger.debug(`visiting ${name}, path: ${path}`);
     if (path.indexOf(name) !== -1) {
-      throw new Error(
-        `found cycle in dependency graph: ${path.join(' -> ')} -> ${name}`
+      this.logger.warn(
+      `found cycle in dependency graph: ${path.join(' -> ')} -> ${name}`
       );
+      return;
     }
     const node = graph.get(name);
     if (!node) {