Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circular deps #2453

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: circular deps #2453

wants to merge 1 commit into from

Conversation

reggi
Copy link

@reggi reggi commented Dec 12, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2452 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 12, 2024
@reggi reggi force-pushed the reggi/circular-debs branch from 0833c91 to 2a999f4 Compare December 12, 2024 05:08
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Dec 12, 2024
Fart10
Fart10 approved these changes Dec 24, 2024
View reviewed changes
Copy link

@Fart10 Fart10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fart10 Fart10 Fart10 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: handle circular dependencies
2 participants
@reggi @Fart10