deps: update logback version to 1.5.19 #3972
Conversation
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, specifically upgrading various Logback components within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the logback dependency to version 1.5.19, likely to address a security vulnerability as indicated by the description. The changes correctly update the version property and the hardcoded versions in various Maven profiles. My review includes suggestions to replace the hardcoded versions with the existing Maven property to improve maintainability and ensure consistency across all profiles.
| <version>1.5.19</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-core</artifactId> | ||
| <version>1.5.16</version> | ||
| <version>1.5.19</version> |
There was a problem hiding this comment.
To improve maintainability and ensure version consistency across profiles, consider using the ${slf4j1-logback.version} property for both logback-classic and logback-core instead of hardcoded versions. This centralizes logback version management.
| <version>1.5.19</version> | |
| <scope>test</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>ch.qos.logback</groupId> | |
| <artifactId>logback-core</artifactId> | |
| <version>1.5.16</version> | |
| <version>1.5.19</version> | |
| <version>${slf4j1-logback.version}</version> | |
| <scope>test</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>ch.qos.logback</groupId> | |
| <artifactId>logback-core</artifactId> | |
| <version>${slf4j1-logback.version}</version> |
| <version>1.5.19</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-core</artifactId> | ||
| <version>1.3.15</version> | ||
| <version>1.5.19</version> |
There was a problem hiding this comment.
For consistency and better maintainability, please use the ${slf4j1-logback.version} property here as well for both logback-classic and logback-core. This makes future updates easier.
| <version>1.5.19</version> | |
| <scope>test</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>ch.qos.logback</groupId> | |
| <artifactId>logback-core</artifactId> | |
| <version>1.3.15</version> | |
| <version>1.5.19</version> | |
| <version>${slf4j1-logback.version}</version> | |
| <scope>test</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>ch.qos.logback</groupId> | |
| <artifactId>logback-core</artifactId> | |
| <version>${slf4j1-logback.version}</version> |
|
|
https://github.com/googleapis/sdk-platform-java/security/dependabot/43