Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce permissions on gke-node service account. #250

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

ensonic
Copy link
Contributor

@ensonic ensonic commented Nov 14, 2023

  • monitoring.viewer is already covered by monitoring.metricWriter
  • stackdriver.resourceMetadata.writer is unused

Tested on robco-ensonic gcp project.

@ensonic ensonic requested a review from drigz November 14, 2023 09:31
@drigz
Copy link
Contributor

drigz commented Nov 14, 2023

The stackdriver/monitoring roles are recommended here: https://cloud.google.com/kubernetes-engine/docs/troubleshooting/troubleshoot-dashboards#write_permissions but not sure if they're actually necessary or if that's out of date.

* monitoring.viewer is already covered by monitoring.metricWriter
* also use the more compact for of specifying the roles

Tested on robco-ensonic gcp project.
@ensonic ensonic merged commit 2a7cbc0 into main Nov 14, 2023
5 checks passed
@ensonic ensonic deleted the ensonic/terraform branch November 14, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants