Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile test coverage to GitHub Action Workflow CI #863

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Makefile test coverage to GitHub Action Workflow CI #863

wants to merge 1 commit into from

Conversation

vorburger
Copy link

part of #862

@vorburger
Copy link
Author

Oh, the GitHub Action Workflow CI as-is only runs on main and therefore can't test if this actually works...

... let me first raise another PR to propose running it on all PRs, and then we'll see if this actually works.

@vorburger vorburger marked this pull request as draft October 28, 2023 14:03
@vorburger vorburger mentioned this pull request Oct 28, 2023
Open
vorburger
vorburger commented Oct 31, 2023
View reviewed changes
.github/workflows/go.yml

- name: Make
working-directory: claat
run: make all release
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should this be using -C and/or -j, as it used to here? (NB: #886)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vorburger