Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: Bump gulp-sass from 4.0.2 to 5.1.0 (fixes #882) #884

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vorburger
Copy link

@vorburger vorburger commented Oct 29, 2023

fixes #882

@vorburger vorburger marked this pull request as draft October 29, 2023 01:11
@vorburger
Copy link
Author

fixes #882

Wehl... not really, yet; it currently fails like this - how do we fix this:

$ ./node_modules/.bin/gulp serve
[02:18:09] Using gulpfile ~/git/github.com/googlecodelabs/tools/site/gulpfile.js
[02:18:09] Starting 'serve'...
[02:18:09] Starting 'build'...
[02:18:09] Starting 'clean'...
[02:18:09] Starting 'clean:build'...
[02:18:09] Starting 'clean:dist'...
[02:18:09] Finished 'clean:dist' after 5.99 ms
[02:18:09] Finished 'clean:build' after 9.38 ms
[02:18:09] Finished 'clean' after 10 ms
[02:18:09] Starting 'build:codelabs'...
[02:18:09] Finished 'build:codelabs' after 1.49 ms
[02:18:09] Starting 'build:css'...
[02:18:09] Finished 'build:css' after 22 ms
[02:18:09] Starting 'build:scss'...
[02:18:09] 'build:scss' errored after 252 ms
[02:18:09] Error in plugin "gulp-sass"
Message:
    app/styles/_categories.scss
Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
Details:
    formatted: Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    line: 50
    column: 9
    file: /home/vorburger/git/github.com/googlecodelabs/tools/site/app/styles/_categories.scss
    status: 1
    messageFormatted: app/styles/_categories.scss
Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    messageOriginal: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    relativePath: app/styles/_categories.scss
    domainEmitter: [object Object]
    domainThrown: false

[02:18:09] 'build' errored after 288 ms
[02:18:09] 'serve' errored after 291 ms

@arielmagbanua
Copy link

arielmagbanua commented Mar 28, 2024

fixes #882

Wehl... not really, yet; it currently fails like this - how do we fix this:

$ ./node_modules/.bin/gulp serve
[02:18:09] Using gulpfile ~/git/github.com/googlecodelabs/tools/site/gulpfile.js
[02:18:09] Starting 'serve'...
[02:18:09] Starting 'build'...
[02:18:09] Starting 'clean'...
[02:18:09] Starting 'clean:build'...
[02:18:09] Starting 'clean:dist'...
[02:18:09] Finished 'clean:dist' after 5.99 ms
[02:18:09] Finished 'clean:build' after 9.38 ms
[02:18:09] Finished 'clean' after 10 ms
[02:18:09] Starting 'build:codelabs'...
[02:18:09] Finished 'build:codelabs' after 1.49 ms
[02:18:09] Starting 'build:css'...
[02:18:09] Finished 'build:css' after 22 ms
[02:18:09] Starting 'build:scss'...
[02:18:09] 'build:scss' errored after 252 ms
[02:18:09] Error in plugin "gulp-sass"
Message:
    app/styles/_categories.scss
Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
Details:
    formatted: Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    line: 50
    column: 9
    file: /home/vorburger/git/github.com/googlecodelabs/tools/site/app/styles/_categories.scss
    status: 1
    messageFormatted: app/styles/_categories.scss
Error: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    messageOriginal: Expected identifier.
  ┌──> app/styles/_categories.scss
50│   %bg-#{$color} {
  │         ^^^^^^
  ╵
  ╷
1 │ %bg-#4285f4
  │      ━ error in interpolated output
  ╵
  app/styles/_categories.scss 50:9    codelab-card()
  app/styles/_categories.scss 79:1    @import
  app/styles/_codelab-card.scss 18:9  @import
  app/styles/main.scss 22:9           root stylesheet
    relativePath: app/styles/_categories.scss
    domainEmitter: [object Object]
    domainThrown: false

[02:18:09] 'build' errored after 288 ms
[02:18:09] 'serve' errored after 291 ms

I recent encountered this error, I think the current scss implementations will not work with newer version of sass or gulp-sass. Try to keep all the versions for now, if you can't install all node packages try downgrading your node to at least v10.24.1. You can also use v11.15.0 as well, I have tested it personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

site: npm install: SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
2 participants