-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: Bump gulp-sass from 4.0.2 to 5.1.0 (fixes #882) #884
base: main
Are you sure you want to change the base?
Conversation
Wehl... not really, yet; it currently fails like this - how do we fix this: $ ./node_modules/.bin/gulp serve
[02:18:09] Using gulpfile ~/git/github.com/googlecodelabs/tools/site/gulpfile.js
[02:18:09] Starting 'serve'...
[02:18:09] Starting 'build'...
[02:18:09] Starting 'clean'...
[02:18:09] Starting 'clean:build'...
[02:18:09] Starting 'clean:dist'...
[02:18:09] Finished 'clean:dist' after 5.99 ms
[02:18:09] Finished 'clean:build' after 9.38 ms
[02:18:09] Finished 'clean' after 10 ms
[02:18:09] Starting 'build:codelabs'...
[02:18:09] Finished 'build:codelabs' after 1.49 ms
[02:18:09] Starting 'build:css'...
[02:18:09] Finished 'build:css' after 22 ms
[02:18:09] Starting 'build:scss'...
[02:18:09] 'build:scss' errored after 252 ms
[02:18:09] Error in plugin "gulp-sass"
Message:
app/styles/_categories.scss
Error: Expected identifier.
┌──> app/styles/_categories.scss
50│ %bg-#{$color} {
│ ^^^^^^
╵
╷
1 │ %bg-#4285f4
│ ━ error in interpolated output
╵
app/styles/_categories.scss 50:9 codelab-card()
app/styles/_categories.scss 79:1 @import
app/styles/_codelab-card.scss 18:9 @import
app/styles/main.scss 22:9 root stylesheet
Details:
formatted: Error: Expected identifier.
┌──> app/styles/_categories.scss
50│ %bg-#{$color} {
│ ^^^^^^
╵
╷
1 │ %bg-#4285f4
│ ━ error in interpolated output
╵
app/styles/_categories.scss 50:9 codelab-card()
app/styles/_categories.scss 79:1 @import
app/styles/_codelab-card.scss 18:9 @import
app/styles/main.scss 22:9 root stylesheet
line: 50
column: 9
file: /home/vorburger/git/github.com/googlecodelabs/tools/site/app/styles/_categories.scss
status: 1
messageFormatted: app/styles/_categories.scss
Error: Expected identifier.
┌──> app/styles/_categories.scss
50│ %bg-#{$color} {
│ ^^^^^^
╵
╷
1 │ %bg-#4285f4
│ ━ error in interpolated output
╵
app/styles/_categories.scss 50:9 codelab-card()
app/styles/_categories.scss 79:1 @import
app/styles/_codelab-card.scss 18:9 @import
app/styles/main.scss 22:9 root stylesheet
messageOriginal: Expected identifier.
┌──> app/styles/_categories.scss
50│ %bg-#{$color} {
│ ^^^^^^
╵
╷
1 │ %bg-#4285f4
│ ━ error in interpolated output
╵
app/styles/_categories.scss 50:9 codelab-card()
app/styles/_categories.scss 79:1 @import
app/styles/_codelab-card.scss 18:9 @import
app/styles/main.scss 22:9 root stylesheet
relativePath: app/styles/_categories.scss
domainEmitter: [object Object]
domainThrown: false
[02:18:09] 'build' errored after 288 ms
[02:18:09] 'serve' errored after 291 ms |
I recent encountered this error, I think the current |
fixes #882