Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skrifa] autohint: public GlyphStyles type #1086

Merged
merged 2 commits into from
Aug 16, 2024
Merged

[skrifa] autohint: public GlyphStyles type #1086

merged 2 commits into from
Aug 16, 2024

Conversation

dfrg
Copy link
Member

@dfrg dfrg commented Aug 15, 2024

Exposes the glyph style map as a public type and wrapped in an Arc to make it shareable among multiple autohinting instances.

Exposes the glyph style map as a public type and wrapped in an `Arc` to make it shareable among multiple autohinting instances.
Copy link
Contributor

@drott drott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns in terms of API shape, a minor naming suggestion and question regarding the Arc type.

skrifa/src/outline/mod.rs Show resolved Hide resolved
skrifa/src/outline/autohint/instance.rs Show resolved Hide resolved
Copy link
Contributor

@drott drott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfrg dfrg merged commit 50ce82f into main Aug 16, 2024
10 checks passed
@dfrg dfrg deleted the glyphstyles branch August 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants