-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare 1.0 for libraries actively used by Chrome #1329
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this makes sense but I have some minor hesitancy about doing it super casually; at the very least I'd like to go through open issues and see if there's anything obvious that we'll want to break API for.
other current blockers:
- we know we're breaking the api in the ivs module of font_test_data, so it's worth at least doing that first
- ...nothing I can think of offhand 🤷
I would argue we aren't doing it casually. We're acknowledging that we're shipping to a very large userbase and now need to be a bit more careful wrt compatibility. This makes the versioning reflect reality on the ground.
Agreed, imho that's the only thing we need to block on |
Based on fontations' history, I'm assuming there will still be regular releases that are breaking from an API perspective (if not from a behaviour perspective)? So we should expect 2.0, 3.0 release soon and this just indicated maturity? Or is this indicating a change in policy with regard to API breaks? |
write-fonts will still stay on minor versions and should expect regular breaking changes, but we're going to try and avoid too much churn in That said, I expect we likely will need at least some breaking changes in read-fonts and skrifa in the future, in which case we would go to 2.0, 3.0 etc. |
This sounds good to me as an open source user of these crates (I'm not currently using |
Fair point, it is 100% true that we are not currently thinking very much about consumers other than chrome and |
We are LIVE from the sold out Chrome stable user base. Declare 1.0 for relevant libraries (
$ ./resources/scripts/bump-version.sh font-test-data font-types read-fonts skrifa major
)BLOCKED ON:
read-fonts
#1263 Moving variable font logic into read-fonts