Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolating component axis values across the "default" border #46

Merged
merged 3 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/fontra_compile/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,29 @@ def applyAxisMapToAxisValues(axis) -> tuple[float, float, float]:
return (minValue, defaultValue, maxValue)


def axisTuple(axis) -> tuple[float, float, float]:
return (axis.minValue, axis.defaultValue, axis.maxValue)
def axisTuple(axis, fixAsymmetricAxes=True) -> tuple[float, float, float]:
minValue, defaultValue, maxValue = axis.minValue, axis.defaultValue, axis.maxValue
if fixAsymmetricAxes and minValue < defaultValue < maxValue:
# Variable component axis values can interpolate across the "default" border.
# For example if an axis goes from 0 to 1000 with the default at 200, a variable
# component may interpolate this from 100 to 600. In the VARC table, all axis
# values will be normalized to (-1, 0, +1). So 100 would normalize to -0.5 and 600
# would normalize to +0.5. But this means that interpolation does not work the
# same in the normalized space. For example, the midpoint between -0.5 and +0.5
# is 0, but the midpoint between 100 and 600 is 350, which would normalize to
# 0.1875. This is obviously a problem.
# To work around it, we extend either side of the axis so the distance between
# minValue and defaultValue becomes the same as the distance between defaultValue
# and maxValue.
# The downside of this approach is that axis values will no longer be clipped to
# their original minimum or maximum, so we may create new edge cases here.
minDiff = defaultValue - minValue
maxDiff = maxValue - defaultValue
if minDiff > maxDiff:
maxValue = defaultValue + minDiff
elif minDiff < maxDiff:
minValue = defaultValue - maxDiff
return minValue, defaultValue, maxValue


def newAxisDescriptor(
Expand Down
Loading