Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI for "Location base" in the source properties UI #1662

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add UI for "Location base" in the source properties UI #1662

wants to merge 8 commits into from

Conversation

justvanrossum
Copy link
Collaborator

This fixes #1640.

Possible improvements:

  • better looking popup menu:
    • apply styling (maybe hard)
    • implement custom web component
  • The code should be able to know which sources are not eligable because they are already used, so we can dim those

@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from 348af9f to 5ea6ce1 Compare September 24, 2024 09:15
@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from e2154e6 to 3d49983 Compare October 4, 2024 07:32
@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from 3d49983 to 4c670dd Compare October 4, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[locationBase] Adjust "add source" / "edit source properties" dialog
1 participant
@justvanrossum