Overhaul language definitions in preparation for GF_Glyphset langdef-based overhaul #81
Conversation
There was a problem hiding this comment.
This is getting tricky. Some of these are not actually required and some of these are only required in some orthographies of a single language that has multiple orthographies.
Ligature ij is not required to support Dutch but may be nice to have for typesetting. Fonts don't have to have it to support Dutch. I would hard code this in glyphssets when handling Dutch, not in the language data base exemplar set. Maybe we need additional data to represent this in gflanguages.
Sharp s is used in some Low German orthographies but not in others. So fonts may support some orthographies of Low German even if they don't have it. For this we need to allow multiple orthographies in gflanguages.
I don't think these are blocking this PR but they'll need to be addressed at some point soon because they misrepresent language requirements.
|
@moyogo I removed the ij and IJ from Dutch. I added the lowercase ß to Low German only because it already had an uppercase version defined previously, which on its own is certainly nonsensical. |
|
I agree with this PR. I don't see any danger here in removing these glyphs. My only note: the removal of hyphen2 and softhyphen resulted in a double space. |
|
Okay, I removed the section sign and all duplicate spaces |
|
Today I will put together a document that outlines in which order the various repos need to be merged and releases cut, so please wait with merging. |
| @@ -2,3 +2,5 @@ | |||
| *.egg-info | |||
| *__pycache__ | |||
| Lib/gflanguages/_version.py | |||
|
|
|||
| @@ -8,5 +8,5 @@ region: "LV" | |||
| exemplar_chars { | |||
| base: "A Ā B C Č D E Ē F G Ģ H I Ī J K Ķ L Ļ M N Ņ O Ō P R S Š T U Ū V Y Z Ž a ā b c č d e ē f g ģ h i ī j k ķ l ļ m n ņ o ō p r s š t u ū v y z ž" | |||
| auxiliary: "Q W X q w x" | |||
| marks: "◌̄ ◌̌ ◌̧" | |||
| marks: "◌̄ ◌̌ ◌̧ ◌ ̒" | |||
There was a problem hiding this comment.
Adding 0x0312 COMBINING TURNED COMMA ABOVE to Latvian (lv), Latgalian (ltg), Prussian (prg) is incorrect. While the glyph may be used as a component of ģ, the character is not used in those languages.
This PR removes various punctuation and other symbols from all languages in preparation of using the language definitions to check for language shaping in fontbakery.
Duplicate whitespace was also removed which applied to quite a few text sample as well.