Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to delete all tickets in OM #152
How to delete all tickets in OM #152
Changes from all commits
b481b1a
825ea08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this handle pending tickets or tickets that are already assigned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what is the agreement on #1136? I thought this doc was intended to document how to delete all tickets in OM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More than the documentation itself, I am concerned about the implementation for:
googleforgames/open-match#1151
Looks like that goes through query service - so I assume you will only get Active IDs? So is this statement on that API proto accurate:
If the Pool contains no Filters, QueryTicketIds will return all TicketIDs in the state storage. ?
The primary user scenario here was to have an ability to cleanup Open Match state storage - and if there is a simpler way to do that, we should consider that. Providing a state specific API may be cleaner (get all pending / get all assigned / get all in all states) but thats a lower priority.
Also, we dont expect this to be called at scale - so going through query cache for this is not a requirement.