Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

A draft refactoring for ACLs based on #110. #113

Open
wants to merge 1 commit into
base: sri-acls
Choose a base branch
from

Conversation

wiarlawd
Copy link
Contributor

  • Remove persistent if statements, especially checking whether aclSql is null.
  • Make it clear that there are two choices, whether aclSql is null,
    and whether we are coming from getDocContent or isUserAuthorized.
  • Make most of the config decisions at init-time.

Notes:

  • Indentation is incorrect to reduce diffs.
  • Additional refactoring can eliminate the additional arguments for
    buildAcl and getAclFromDb by moving them inside of AclHandler.

* Remove persistent if statements, especially checking whether aclSql is null.
* Make it clear that there are two choices, whether aclSql is null,
  and whether we are coming from getDocContent or isUserAuthorized.
* Make most of the config decisions at init-time.

Notes:
* Indentation is incorrect to reduce diffs.
* Additional refactoring can eliminate the additional arguments for
  buildAcl and getAclFromDb by moving them inside of AclHandler.
@wiarlawd wiarlawd force-pushed the wiarlawd-refactor branch from dd42e40 to bb734ec Compare March 2, 2018 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant