Heat Map with Backend Data #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gracetian6
commented
Jul 31, 2020
•
gracetian6
commented
laptou
approved these changes
Aug 4, 2020
jessicaslaughter
requested changes
Aug 6, 2020
| heatMapValues.push(new HeatMapRow(data.slice(i, i + numRows))); | ||
| } | ||
| return heatMapValues.reverse(); | ||
| } | ||
|
|
||
| /** | ||
| * renders heat map onto html | ||
| * @param {number[]} data array of all 0s/1s heat map data | ||
| * @param {number} dataLength size of data array | ||
| * @param {number[]} allBinaryData array of all 0s/1s heat map data |
There was a problem hiding this comment.
consider renaming to just binaryData, allBinaryData insinuates that there's some other array with just a segment of the data, which there isn't so we can simplify this name
| @@ -88,4 +88,9 @@ function createHeatMap(data, dataLength) { | |||
| chart.render(); | |||
| } | |||
|
|
|||
| createHeatMap(likedMusicBinaryHist, TOTAL_LIKED); | |||
| GENRE_ANALYSIS.then((genreAnalysisInfo) => { | |||
| const LIKED_MUSIC_BINARY_HIST = makeBinaryArr( | |||
There was a problem hiding this comment.
nit: I don't think this is a true constant, it should just use lowerCamelCase
jpnickolas
approved these changes
Aug 7, 2020
| } | ||
|
|
||
| export const GENRE_ANALYSIS_PROMISE = fetchMusicGenre(); |
There was a problem hiding this comment.
See earlier PR about not calling a function with side effects (such as making a web request) on import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.