Skip to content
This repository has been archived by the owner on Jun 22, 2021. It is now read-only.

add event overlay #558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Oct 30, 2019

supersedes #518

@ashleahhill I rebased this for you. only thing I need to look into is the impact on #531 and aria labels submitted by @crutchcorn.

closes #506

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files          12       12           
  Lines         486      486           
  Branches       73       73           
=======================================
  Hits          258      258           
  Misses        228      228
Impacted Files Coverage Δ
packages/markermanager/src/markermanager.ts 42.73% <0%> (ø) ⬆️
packages/markermanager/src/utils.ts 100% <0%> (ø) ⬆️
packages/markermanager/src/gridbounds.ts 50% <0%> (ø) ⬆️
packages/ogc/src/wmsmaptype.ts
packages/ogc/src/wmslayer.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eb0e5...1bb7600. Read the comment docs.

@jpoehnelt
Copy link
Contributor Author

@ashleahhill can you comment with @googlebot I consent. see #558 (comment)

@jpoehnelt
Copy link
Contributor Author

@ashleahhill ping for cla approval

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zIndex for @google/markerclusterer icons is too large
3 participants