Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): Readded support for multiple groups and made it more… #455

Closed
wants to merge 1 commit into from

Conversation

lwcorp
Copy link
Contributor

@lwcorp lwcorp commented Apr 15, 2024

Description

  1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
  2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
  3. Added support for avoiding blocked groups (e.g. external ones)
  4. Simplified both functions' code

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

… integrated + avoided blocked groups

1. Undid the removal of the support for multiple groups
2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
3. Added support for avoiding blocked groups (e.g. external ones)
4. Simplified both functions' code
Copy link

conventional-commit-lint-gcf bot commented Apr 15, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@lwcorp lwcorp changed the title feat(calendar): Readded support for multiple groups and made it more integrated + avoided blocked groups feat(calendar): Readded support for multiple groups and made it more… Apr 15, 2024
@lwcorp lwcorp closed this Apr 15, 2024
@lwcorp
Copy link
Contributor Author

lwcorp commented Apr 16, 2024

Merged with #456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants