feat!: autostart option #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may set `{ opts = { autostart = false } }` to prevent alpha from drawing on `VimEnter`
BREAKING CHANGES:
Refactors alpha.lua to use neovim 0.7+ APIs
|
it looks like neovim/neovim#14670 was fixed at some point, so I'll look over this once i get some time |
The way `end_ln` was incremented before `alpha.highlight` meant that two calls to `vim.api.nvim_buf_add_highlight` were made for each text line (i.e. two highlight groups for each line rather than one), causing highlighting to affect the subsequent line.
Improper handling of `nil` `opts` caused an early conditional short-circuit that prevented the text line from being padded at all.
goolord
added a commit
that referenced
this pull request
Jul 16, 2022
* feat!: autostart option
Users may set `{ opts = { autostart = false } }` to prevent alpha from drawing on `VimEnter`
BREAKING CHANGES:
Refactors alpha.lua to use neovim 0.7+ APIs
* style: refactors aucmd callbacks to pass state
* fix(debug): incorrect argument
* fix padding.left for text
* remove print
* use autocmd api, don't store old window options
Co-authored-by: Zachary Churchill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may set
{ opts = { autostart = false } }to prevent alpha from drawing onVimEnterBREAKING CHANGES:
Refactors alpha.lua to use neovim 0.7+ APIs
See #51
Closes #66
Fixes #106