-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Kadai3-1-annkara #28
Open
annkara
wants to merge
50
commits into
master
Choose a base branch
from
kadai3-1-annkara
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- README.mdを追加
テストコードにて実ファイルのI/Oが発生しているので、ファイルを利用しないテストコードの実装を検討する。
最初のテストコードを追加
- ディレクトリを絶対パスへ変換 現状、動かないしデバッグしづらいのでデバッグ情報を出力できるように修正する。
2. デバッグログの出力を追加 3. 不要な絶対パスへの変換処理を削除
ディレクトリ名を渡してしまうとテストに失敗してしまうので、オプションの解析のみテスト実施
テーブル駆動テスト形式に修正。 テストヘルパーを利用する形に修正したが、異常系のテストがまだ実施できていない。
cli.goからディレクトリのトラバース処理を、新規パッケージ・新規ファイルへと移動。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.