【課題３】タイピングゲームと分割ダウンローダー #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Sep 24, 2019
| errgroup "golang.org/x/sync/errgroup" | ||
| ) | ||
|
|
||
| var COUNT = 4 |
There was a problem hiding this comment.
定数であれば、constで先頭を大文字にするとパッケージ外に公開されます
tenntenn
reviewed
Sep 24, 2019
|
|
||
| func main() { | ||
|
|
||
| url := "https://misc.laboradian.com/test/003" |
tenntenn
reviewed
Sep 24, 2019
| header, err := HeaderInfo(url) | ||
|
|
||
| if err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
エラーであれば、os.Stderrに出して、os.Exit(1)とかで終了する
tenntenn
reviewed
Sep 24, 2019
| } | ||
|
|
||
| func HeaderInfo(url string) (map[string][]string, error) { | ||
| req, _ := http.NewRequest("HEAD", "https://misc.laboradian.com/test/003/", nil) |
tenntenn
reviewed
Sep 24, 2019
| func HeaderInfo(url string) (map[string][]string, error) { | ||
| req, _ := http.NewRequest("HEAD", "https://misc.laboradian.com/test/003/", nil) | ||
|
|
||
| client := new(http.Client) |
tenntenn
reviewed
Sep 24, 2019
| defer resp.Body.Close() | ||
|
|
||
| if err != nil { | ||
| fmt.Printf("ioutil err: %v", err) |
There was a problem hiding this comment.
エラーの表示も立派なエラーハンドリングなので、2重にハンドリングしない。
表示するなら表示する、returnするならreturnする。
tenntenn
reviewed
Sep 24, 2019
| return resp.Header, nil | ||
| } | ||
|
|
||
| func canRangeAccess(header map[string][]string) bool { |
tenntenn
reviewed
Sep 24, 2019
| func canRangeAccess(header map[string][]string) bool { | ||
| v, ok := header["Accept-Ranges"] | ||
|
|
||
| if ok { |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| func Download(url, byteRange string) error { | ||
|
|
||
| req, _ := http.NewRequest("GET", url, nil) |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| client := new(http.Client) | ||
| resp, err := client.Do(req) | ||
| // TODO: エラー処理する? |
tenntenn
reviewed
Sep 24, 2019
| _, fileName := path.Split(url) | ||
| fmt.Println(url, byteRange, fileName) | ||
|
|
||
| file, err := os.Create(path.Join("./tmp/", fileName+"_"+byteRange)) |
There was a problem hiding this comment.
ファイルにpathパッケージは使わない。filepathを使う。
一時ファイルはioutilとかを使う https://golang.org/pkg/io/ioutil/#TempDir
tenntenn
reviewed
Sep 24, 2019
| } | ||
| _, err = io.Copy(file, resp.Body) | ||
| if closeErr := file.Close(); err == nil { | ||
| err = closeErr |
tenntenn
reviewed
Sep 24, 2019
| } | ||
|
|
||
| func NthRange(length, parallel_num, n int) string { | ||
| bytes_per_file := length / parallel_num |
There was a problem hiding this comment.
識別子（変数名など）はスネークケースを使わない。キャメルケースを使う。
tenntenn
reviewed
Sep 24, 2019
| func NthRange(length, parallel_num, n int) string { | ||
| bytes_per_file := length / parallel_num | ||
| if n == 1 { | ||
| return "0-" + strconv.Itoa(bytes_per_file) |
tenntenn
reviewed
Sep 24, 2019
| if n == 1 { | ||
| return "0-" + strconv.Itoa(bytes_per_file) | ||
| } else if n < parallel_num { | ||
| return strconv.Itoa(bytes_per_file*(n-1)+1) + "-" + strconv.Itoa(bytes_per_file*n) |
tenntenn
reviewed
Sep 24, 2019
| readBytes, err := ioutil.ReadAll(f) | ||
| writeBytes = append(writeBytes, readBytes) | ||
|
|
||
| if err := f.Close(); err != nil { |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| fmt.Println(fileName) | ||
|
|
||
| err := ioutil.WriteFile(fileName, bytes.Join(writeBytes, emptyByte), 0644) |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| words, err := RegisterWords() | ||
| if err != nil { | ||
| fmt.Println("err") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題３
1.タイピングゲームを作ろう
2.分割ダウンローダを作ろう