Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa: fix abiType && abiMethoOf #392

Merged
merged 1 commit into from
Jun 25, 2024
Merged

ssa: fix abiType && abiMethoOf #392

merged 1 commit into from
Jun 25, 2024

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Jun 22, 2024

fix abi for lib/internal/reflectlite

  • abiType load T before *T
  • fix abiMethodOf

@visualfc visualfc changed the title ssa: fix abiType && abiMethoOf [wip] ssa: fix abiType && abiMethoOf Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.54%. Comparing base (5238c24) to head (16352df).

Files Patch % Lines
ssa/abitype.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   97.59%   97.54%   -0.05%     
==========================================
  Files          19       19              
  Lines        4114     4122       +8     
==========================================
+ Hits         4015     4021       +6     
- Misses         82       83       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visualfc visualfc force-pushed the rlite branch 2 times, most recently from b221d9c to 0d8c89b Compare June 22, 2024 22:51
@visualfc visualfc changed the title [wip] ssa: fix abiType && abiMethoOf ssa: fix abiType && abiMethoOf Jun 22, 2024
@visualfc visualfc force-pushed the rlite branch 5 times, most recently from 901354d to 6a1ddbf Compare June 25, 2024 02:14
@xushiwei xushiwei merged commit f415110 into goplus:main Jun 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants