Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cl: add Context; rm cl.syminfo #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cl: add Context; rm cl.syminfo #542

wants to merge 1 commit into from

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Jul 19, 2024

  • add cl.Context
  • rm cl.symInfo parser for comment

@visualfc visualfc force-pushed the ctx branch 3 times, most recently from 907a8fa to 33d1661 Compare July 19, 2024 22:45
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.22%. Comparing base (29ec301) to head (1f5b4ba).

Files with missing lines Patch % Lines
compiler/internal/build/build.go 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   89.49%   89.22%   -0.28%     
==========================================
  Files          45       45              
  Lines        8618     8596      -22     
==========================================
- Hits         7713     7670      -43     
- Misses        739      759      +20     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visualfc visualfc changed the title [wip] build: add cl.Context for linkname build: add cl.Context for linkname Jul 19, 2024
@visualfc visualfc force-pushed the ctx branch 2 times, most recently from e42023e to ef7d244 Compare July 22, 2024 22:47
cl/compile.go Outdated Show resolved Hide resolved
@visualfc visualfc force-pushed the ctx branch 4 times, most recently from a31368d to 8991455 Compare August 2, 2024 01:12
@visualfc visualfc force-pushed the ctx branch 2 times, most recently from 01373f0 to cf099cc Compare August 7, 2024 01:12
@visualfc visualfc force-pushed the ctx branch 2 times, most recently from 12179d5 to 18c312c Compare August 14, 2024 14:19
@visualfc visualfc changed the title build: add cl.Context for linkname cl: add Context; rm cl.syminfo Aug 22, 2024
@visualfc visualfc force-pushed the ctx branch 2 times, most recently from ee35602 to eeb4469 Compare December 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants