Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa: closure use org signature #880

Merged
merged 4 commits into from
Nov 26, 2024
Merged

ssa: closure use org signature #880

merged 4 commits into from
Nov 26, 2024

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Nov 25, 2024

  • ssa: cvtFunc keep signature org variadic. ( toLLVMFunc variadic by NameValist )
  • ssa: cvtClosure remove closureCtx param
  • internal/abi: fix abi.Type.NumMethod
  • internal/lib/reflect: call variadic check

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (bab5c05) to head (8fb0dfa).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   95.54%   95.55%           
=======================================
  Files          22       22           
  Lines        6246     6251    +5     
=======================================
+ Hits         5968     5973    +5     
  Misses        246      246           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visualfc visualfc changed the title ssa: toLLVMFunc by NameValist ssa: closure use org signature Nov 25, 2024
@visualfc visualfc force-pushed the valist branch 3 times, most recently from 400422e to 6c68d9a Compare November 26, 2024 02:44
@xushiwei xushiwei merged commit 25bc848 into goplus:main Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants